Fix the Kokkos testing compilation error on Frontier #4366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vicente Adolfo Bolea Sanchez <[email protected]>
anagainaru
force-pushed
the
kokkos-testing-fix
branch
from
e46d3dc to
b17c40c
Compare
vicentebolea
approved these changes
Oct 15, 2024
Collaborator
vicentebolea
left a comment
vicentebolea
left a comment
There was a problem hiding this comment.
waiting for frontier CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #4358 (closing it was a mistake)
If hipcc is used as the CXX compiler there is no error, but the CI is using g++ so we need to manually set the CXX compiler to whatever was used to build Kokkos.
The rocm version had to be updated to rocm/5.7.1 in the frontier CI due to an incompatibility between the g++ version in PrgEnv-gnu/8.5.0 and the hipcc version in rocm/5.4.3
The Kokkos version had to be updated to > 4.0.0 due to a warning with 3.7.01 and newer rocm compilers.
@vicentebolea thank you for catching the mistake.