Separate the derived variable testing in MPI and not MPI functions #4395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
force-pushed
the
derived-mpi-testing
branch
from
2047adb to
de3c6be
Compare
anagainaru
force-pushed
the
derived-mpi-testing
branch
from
de3c6be to
550a058
Compare
Member
|
Whoops. Merge conflicts... |
Member
Author
Pushing too many things at the same time :) |
eisenhauer
approved these changes
Nov 8, 2024
Member
|
MSAN keeps timing out here. I'll give it one more shot and then merge it anyway.... |
Member
Author
|
Maybe squash merge, I didn't have time to clean the history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vector operations (cross and magnitude), curl and magnitude of curl are left as serial tests.
The scalar and trig derived expressions are tested both serial and with MPI. Each test writes using MPI processes (with X ranks) and reads all the data on rank 0 where correctness is checked.