Skip to content

Conversation

@eisenhauer
Copy link
Member

No description provided.

@eisenhauer
Copy link
Member Author

Note I have not disturbed the "backward_compatibility" subdirectory which isn't actively involved in testing...

@vicentebolea
Copy link
Collaborator

For extracting these zipped bp files you could leverage cmake -E tar command: https://cmake.org/cmake/help/latest/manual/cmake.1.html#cmdoption-cmake-E-arg-tar

@eisenhauer
Copy link
Member Author

For extracting these zipped bp files you could leverage cmake -E tar command:
Is there some reason to avoid the ARCHIVE_CREATE/EXTRACT functionality in the CMAKE file command? (With the caveat that I couldn't use ARCHIVE_CREATE because I needed more control over the zip command line to try to keep some info out of the archive. This is all due to trying to create archives that are identical except for actual changes in ADIOS file data...)

@vicentebolea
Copy link
Collaborator

For extracting these zipped bp files you could leverage cmake -E tar command:
Is there some reason to avoid the ARCHIVE_CREATE/EXTRACT functionality in the CMAKE file command? (With the caveat that I couldn't use ARCHIVE_CREATE because I needed more control over the zip command line to try to keep some info out of the archive. This is all due to trying to create archives that are identical except for actual changes in ADIOS file data...)

makes sense, file attributes architiving is tricky, I left some comment,

@eisenhauer eisenhauer requested a review from vicentebolea May 15, 2025 20:18
@eisenhauer
Copy link
Member Author

OK, output and uniqueness testing again disabled until I sort discrepancies, but the remainder is significantly cleaned up. Request re-review.

Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of little comments. everything else looks good

@eisenhauer eisenhauer force-pushed the OutputArchive branch 2 times, most recently from ea84bf0 to 849e3cc Compare May 19, 2025 18:28
vicentebolea
vicentebolea previously approved these changes May 19, 2025
@eisenhauer eisenhauer merged commit 4775b32 into ornladios:master May 20, 2025
39 checks passed
@eisenhauer eisenhauer deleted the OutputArchive branch May 20, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants