Skip to content

Conversation

@eisenhauer
Copy link
Member

Or avoid bug. EVPath doesn't like 8-byte messages. Add junk so that it's 16.

anagainaru
anagainaru previously approved these changes Jul 17, 2025
Copy link
Member

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

{
int CloseResponseCondition;
int Status;
size_t unused; // small messages call stack addressing issues?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add in the comment the reason why you are adding this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

anagainaru
anagainaru previously approved these changes Jul 18, 2025
@eisenhauer eisenhauer force-pushed the RestoreTest branch 2 times, most recently from 1230140 to 47aeceb Compare July 21, 2025 20:01
pnorbert
pnorbert previously approved these changes Jul 22, 2025
@eisenhauer eisenhauer force-pushed the RestoreTest branch 2 times, most recently from 916ed24 to d3cfdba Compare July 24, 2025 20:34
@eisenhauer
Copy link
Member Author

Summary of changes:

  • For the moment, disable memory sanitization in two routines in remote_server. Not sure yet if msan is confused by something there or if there's a real problem, but lets get the other things in.
  • Actually test the success of various server operations and raise appropriate client-side exceptions when things fail.
  • freopen server stderr to file /tmp/server_stderr. This is invaluable for getting sanitizer output for the server when it is run in the background as a ctest fixture.
  • there's an adiosNetwork fix to handle odd hostname setups in some VMs and dockers images
  • Change simpleFile memory management to rely upon shared_ptr.
  • Add a "-d filename" option to adios2_remote_server. This is useful in fixture shutdown and causes a file to be dumped to stdout. This can at least get a server log or other file into the raw log from CI.

@eisenhauer
Copy link
Member Author

Changed logging method to avoid std::cout and introduce a log_output() subroutine that uses a lock for mutual exclusion. Previous msan errors were really tsan issues with multiple threads having conflicts on the internal IO buffers.

@eisenhauer eisenhauer enabled auto-merge (squash) July 30, 2025 20:14
@eisenhauer eisenhauer merged commit 7f372d9 into ornladios:master Jul 31, 2025
37 of 39 checks passed
@eisenhauer eisenhauer deleted the RestoreTest branch July 31, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants