-
Notifications
You must be signed in to change notification settings - Fork 146
Restore remote test and fix bug #4590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anagainaru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
| { | ||
| int CloseResponseCondition; | ||
| int Status; | ||
| size_t unused; // small messages call stack addressing issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add in the comment the reason why you are adding this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
1230140 to
47aeceb
Compare
916ed24 to
d3cfdba
Compare
|
Summary of changes:
|
|
Changed logging method to avoid std::cout and introduce a log_output() subroutine that uses a lock for mutual exclusion. Previous msan errors were really tsan issues with multiple threads having conflicts on the internal IO buffers. |
Or avoid bug. EVPath doesn't like 8-byte messages. Add junk so that it's 16.