Stopgap measure for deprecated libfabric macros #4690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottwittenburg
approved these changes
Oct 23, 2025
Collaborator
scottwittenburg
left a comment
scottwittenburg
left a comment
There was a problem hiding this comment.
Thanks @eisenhauer this seems like a good way to allow us to move forward on #4666 without actually having to do all the testing you pointed out there. If you feel like adding some kind of TODO in response to my comment, I'll be happy to re-approve.
scottwittenburg
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libfabric 2.x has deprecated some macros used in the rdma data plane. These macros represent values that are still used internally in a few extant libfabric providers, so we don't really want to kill that code. Instead we borrow a trick from libfabric/include/ofi.h and simply declare our own versions of those macros without the deprecated flag (different names in order to avoid conflicts with those ofi.h declarations). As we move code to new platforms we may need to modify this approach, but for the moment this preserves existing and past functionality without requiring retesting in situations that may be hard to recreate.
This addresses issues raised in PR #4666.