Skip to content

Do not install example binaries in adios2 deployments #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vicentebolea merged 2 commits into from
Nov 16, 2025
Merged

Do not install example binaries in adios2 deployments #4722

vicentebolea merged 2 commits into from
Nov 16, 2025

Conversation

@vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Nov 14, 2025

No description provided.

@vicentebolea vicentebolea requested a review from a team as a code owner November 14, 2025 21:07
@vicentebolea vicentebolea force-pushed the fix-ci branch 5 times, most recently from c1bff84 to acae6da Compare November 14, 2025 22:47
@vicentebolea vicentebolea changed the title wipwiwwip fix non passing static jobs. Nov 14, 2025
@vicentebolea
Copy link
Collaborator Author

vicentebolea commented Nov 14, 2025

@eisenhauer the linking error without any other hint is really hard to debug.

eisenhauer
eisenhauer previously approved these changes Nov 15, 2025
View reviewed changes
Copy link
Member

@eisenhauer eisenhauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, yes. This looks good though. Except still failing some cases...

@vicentebolea vicentebolea force-pushed the fix-ci branch 2 times, most recently from cbeada8 to dd58365 Compare November 16, 2025 03:42
@vicentebolea
Copy link
Collaborator Author

vicentebolea commented Nov 16, 2025

The issue was due to this: ##[warning]You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 28 MB

We need to trim the static builds

@vicentebolea vicentebolea changed the title fix non passing static jobs. Do not install example binaries in adios2 deployments Nov 16, 2025
@vicentebolea vicentebolea changed the base branch from master to release_210 November 16, 2025 04:22
@vicentebolea vicentebolea changed the base branch from release_210 to master November 16, 2025 04:22
@vicentebolea vicentebolea changed the base branch from master to release_211 November 16, 2025 04:22
@vicentebolea
Copy link
Collaborator Author

vicentebolea commented Nov 16, 2025

I have trimmed the static builds so that they remain withing github actions space limits. I have also made the examples only install if they are outside of an adios2 project.

@vicentebolea
Copy link
Collaborator Author

vicentebolea commented Nov 16, 2025

@eisenhauer please re-review this

eisenhauer
eisenhauer approved these changes Nov 16, 2025
View reviewed changes
Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vicentebolea vicentebolea merged commit 747aaff into ornladios:release_211 Nov 16, 2025
40 checks passed
@vicentebolea vicentebolea deleted the fix-ci branch November 16, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eisenhauer eisenhauer eisenhauer approved these changes

@anagainaru anagainaru anagainaru approved these changes

@caitlinross caitlinross Awaiting requested review from caitlinross caitlinross is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicentebolea @eisenhauer @anagainaru