Fix SZ3 3.1+ API compatibility in decompression #4785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SZ3 3.1 changed the SZ_decompress API signature to require char* instead of const char* for the compressed data buffer. Use const_cast to adapt to this change while maintaining const-correctness in our API. The const_cast is safe because SZ_decompress only reads from the buffer and does not modify it. SZ3 3.3.2 restored const-correctness to the API, making the cast a no-op for that version. Tested with SZ3 3.1.8, 3.2.0, and 3.3.2. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
vicentebolea
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SZ3 versions 3.1 and 3.2 differ from released but not available in spack version 3.3. This formulation seems to work with all.