Conversation
hperl
force-pushed
the
oidc-vc
branch
2 times, most recently
from
July 19, 2023 11:53
3407185 to
0b680d0
Compare
7 tasks
hperl
force-pushed
the
oidc-vc
branch
2 times, most recently
from
July 24, 2023 10:59
91991bc to
bc7e338
Compare
aeneasr
reviewed
Jul 25, 2023
aeneasr
left a comment
aeneasr
left a comment
Member
There was a problem hiding this comment.
Got two questions - rest LGTM :)
aeneasr
approved these changes
Aug 3, 2023
aeneasr
left a comment
aeneasr
left a comment
Member
There was a problem hiding this comment.
Tests are failing but otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments