Skip to content

fix: do not store stacktrace in sentinel errors#823

Merged
aeneasr merged 1 commit into
ory:masterfrom
mitar:sentinel
Sep 16, 2024
Merged

fix: do not store stacktrace in sentinel errors#823
aeneasr merged 1 commit into
ory:masterfrom
mitar:sentinel

Conversation

@mitar

@mitar mitar commented Sep 14, 2024

Copy link
Copy Markdown
Contributor

github.com/pkg/errors's New records a stack trace but for sentinel errors you do not want to record a stack trace of Go initialization. One should return errorsx.WithStack(ErrInvalidatedAuthorizeCode) to attach a stack trace with the error.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@mitar mitar requested a review from aeneasr as a code owner September 14, 2024 22:46
@aeneasr aeneasr merged commit 869a37c into ory:master Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants