chore: minor improvements to readability and updated code style#827
Merged
Conversation
zepatrik
commented
Oct 14, 2024
Comment on lines
-3
to
-7
| replace github.com/dgrijalva/jwt-go => github.com/form3tech-oss/jwt-go v3.2.1+incompatible | ||
|
|
||
| replace github.com/gobuffalo/packr => github.com/gobuffalo/packr v1.30.1 | ||
|
|
||
| replace github.com/gorilla/sessions => github.com/gorilla/sessions v1.2.1 |
Member
Author
There was a problem hiding this comment.
These were not (anymore) in the dependencies.
| func RandomBytes(n int) ([]byte, error) { | ||
| bytes := make([]byte, n) | ||
| if _, err := io.ReadFull(rand.Reader, bytes); err != nil { | ||
| return []byte{}, errorsx.WithStack(err) |
Member
Author
There was a problem hiding this comment.
Wrong zero-value returned. Is this a breaking change? I'd argue not.
| keys = append(keys, secrets) | ||
| keys = append(keys, rotatedSecrets...) | ||
|
|
||
| if len(keys) == 0 { |
Member
Author
There was a problem hiding this comment.
Took me quite some time to figure out that the error check after the loop was just this...
alnr
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments