Skip to content

Add ARM docker support #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2021
Merged

Add ARM docker support #49

merged 2 commits into from
Jan 21, 2021

Conversation

mojotalantikite
Copy link
Contributor

This changes the Docker container to build off of openjdk:16-slim-buster to add ARM support for local testing on new Apple M1 silicon.

This addresses points raised in #48.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aeneasr
aeneasr approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@aeneasr aeneasr merged commit 00fc86e into ory:master Jan 21, 2021
@mojotalantikite mojotalantikite deleted the add_arm_docker_support branch January 26, 2021 20:16
@aeneasr
Copy link
Member

aeneasr commented May 10, 2021

I am reverting this because it completely breaks the SDK deploy pipeline

aeneasr added a commit that referenced this pull request May 10, 2021
@aeneasr
fix: revert #49
9bfdb9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mojotalantikite @CLAassistant @aeneasr