-
-
Notifications
You must be signed in to change notification settings - Fork 66
Introduce type annotations #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lonvia : Thank you for this change! I am interested to use/test the type annotations in combination with mypy. Do you plan to release this anytime soon (under a new version number) for pypi? That would make it super-easy to include it in my (pet) project. |
A new release is imminent because I have a couple of bugs piled up where fixes need to be published. However, I would be really grateful if you could give it a quick try before the release to test if I haven't broken things. |
@lonvia : I tested ee760fa with my current pet project. It uses only I had an issue building pyosmium. As far as I could understand, it is related to the usage of Python 3.10. I attach my notes from the process, but apart from maybe adjusting your README there is probably not much you can do about it. I used Ubuntu MATE 22.04.1 LTS.
I am looking forward to your release. Thank you for maintaining pyosmium! 👍👍👍 |
Supersedes #59. Now that the minimum requirement is Python 3.6 it is fairly easy to intermingle the type annotations in the code directly.
Please test this against your typed code to make sure the annotations are correct.