Partial cleanups in VM #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done: arithmetic, comparisons. Todo: in, isa. Probably not: unify, dot.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
This reverts commit 304dfe4, and instead fixes the underlying problem, which was that we were losing source information in sub-queries.
gj
requested changes
Jan 22, 2021
gj
approved these changes
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor VM handling of unbound and partially-bound variables. Main change is that
dot_op_helper,arithmetic_op_helper,comparison_op_helper, anddot_op_helperare now all called throughquery_op_helper, which handles most of the variable cases in a uniform way.isaandunifystill have their own special handling.