This repository was archived by the owner on Mar 18, 2025. It is now read-only.
Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Contributor
Author
|
|
Contributor
Author
|
Upstream's forward-port was merged. After tonight's nightlies are built, we should retrigger CI here. |
Contributor
Author
|
Ahh last night's https://build.osrfoundation.org/job/ign-gazebo7-debbuilder/159/ |
Contributor
Author
|
Yay, the latest nightlies are out and CI is 🟢 |
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of
Requires
This is a subset of
Make use of the roll, pitch and heading fields on the init message when spawning a vehicle.
I also changed the test to run paused, so we don't have the physics affecting the spawn pose and we can check it more precisely.
This takes an alternative approach to #81. Instead of rotating the model to face North by default, we introduce offsets when receiving spawn commands. This means we must be mindful of the fact that the vehicle faces West by default all the time when looking at poses, which is extremely error prone. I'd much rather change the model to match NED / FSK by default, but as explained in #48 (comment), there are physics issues with using a Z-down model that we'll need more time to track down.