This repository was archived by the owner on Mar 18, 2025. It is now read-only.
Use world origin spherical coordinates from SDF if set#177
Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
hidmic
approved these changes
Mar 29, 2022
Collaborator
hidmic
left a comment
There was a problem hiding this comment.
LGTM though I haven't tested it locally just yet.
Collaborator
|
I tested it locally, this is ready to go @chapulina ! |
Contributor
Author
|
CI is broken for other reasons, but the spawn test passed. So merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally,
WorldCommPluginwould set the world origin to coincide with the first spawned vehicle and ignore the coordinates set from SDF. This is useful for generic simulation worlds that can be used for multiple scenarios.But for #146 , we're creating a world that has environment features that need to be precisely geolocated. This means that we need to set the world origin before any vehicles are spawned.
This PR makes sure we support both cases:
<sperical_coordinates>isn't set from SDF, it will be set when the first vehicle is spawned.Test it
Case when there's on
<spherical_coordinates>:ign gazebo empty_environment.sdfbin/LRAUVCase when there's
<spherical_coordinates>:empty_environment.sdfto add spherical coordinates:ign gazebo empty_environment.sdfbin/LRAUV