This repository was archived by the owner on Mar 18, 2025. It is now read-only.
Conversation
hidmic
force-pushed
the
hidmic/surface-wind
branch
from
724931c to
2144080
Compare
Collaborator
Author
|
Most tests will still fail because of #189, but surface winds' ones will pass. |
Collaborator
Author
Member
|
Should we wait for the rework of the tests before merging this. I suspect we will need to move the tests into your new test package? |
Collaborator
Author
Yes. Now that the merge train has started, it'll have to wait. |
hidmic
force-pushed
the
hidmic/surface-wind
branch
2 times, most recently
from
747f28b to
71b3037
Compare
Collaborator
Author
|
@arjo129 ready for final approval. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/surface-wind
branch
from
71b3037 to
f20edb0
Compare
Collaborator
Author
|
Rebased to pull #204 in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149. This patch requires gazebosim/gz-sim#1357.