Open
Conversation
outline the threat model for the app.
rocodes
reviewed
Dec 22, 2025
| Secure the ADB communication channel using a strong key. | ||
| The ADB key is stored in the application sandbox encrypted with a StrongBox key (whenever supported). | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
This is great @TheZ3ro :)
the following 2 also occurred to me:
- User downloads malicious/unwanted content (eg an upstream repo from IndicatorsUpdates is compromised)-- I'm not sure how much we'd prioritize countermeasures at this stage or if it's just a "document for due diligence sake", although there are definitely indicators improvements that one could imagine for later
- User self-scans are detectable (ie adb advertisement on local network, download of iocs, etc): just a matter of clear user documentation
Member
Author
There was a problem hiding this comment.
Right! Thanks, I'm gonna add them as soon as I have some spare time :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR outline the threat model for the app, considering some scenarios