Update Go to 1.24 #688
Merged
Update Go to 1.24 #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Mendoza <[email protected]>
There was a problem hiding this comment.
Use default setup-go action settings that will pull from go mod
I don't think that happens by default.
actions/setup-go#523
go.mod
Outdated
| go 1.23.0 | ||
| go 1.24 |
There was a problem hiding this comment.
1.24.0?
1.24 assumes a .0and works with current tooling but I remember the initial tooling in Go 1.21 or 1.22 throwing errors at this format.
.github/workflows/pr.yaml
Outdated
Comment on lines
11
to
12
| with: | ||
| go-version: '1.21' |
There was a problem hiding this comment.
there's also a stable alias if that helps.
Closed
Signed-off-by: Stephen Augustus <[email protected]>
This instructs action/setup-go to pull the Golang version from go.mod. This should make future upgrades more predictable than using `go-version: stable`. ref: https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file Signed-off-by: Stephen Augustus <[email protected]>
justaugustus
approved these changes
May 17, 2025
There was a problem hiding this comment.
Thanks @jeffmendoza and @spencerschrock!
I stacked two commits on top:
- 7242a07 — drops
toolchaindirective, which can cause problems for consumers - f6550e4 — uses
go.modto determine the version for actions/setup-go
Here's an actions/setup-go snippet from a successful run:
Run actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b
with:
go-version-file: go.mod
check-latest: false
token: ***
cache: true
Setup go version spec 1.24
Attempting to download 1.24...
matching 1.24...
Acquiring 1.24.3 from https://github.com/actions/go-versions/releases/download/1.24.3-14875263452/go-1.24.3-linux-x64.tar.gz
Extracting Go...
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/8390be88-c2cc-4c44-82b3-155163c7b452 -f /home/runner/work/_temp/9102d775-9e54-4898-a9ad-7a0a519c81f0
Successfully extracted go to /home/runner/work/_temp/8390be88-c2cc-4c44-82b3-155163c7b452
Adding to the cache ...
Successfully cached go to /opt/hostedtoolcache/go/1.24.3/x64
Added go to the path
Successfully set up Go version 1.24
/opt/hostedtoolcache/go/1.24.3/x64/bin/go env GOMODCACHE
/opt/hostedtoolcache/go/1.24.3/x64/bin/go env GOCACHE
/home/runner/go/pkg/mod
/home/runner/.cache/go-build
Cache is not found
go version go1.24.3 linux/amd64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use default setup-go action settings that will pull from go mod
I'll mess with cloud build later (will remove the build there).