📖 Fix recommended command to test the image in development #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because no testdata files are actually copied to the image, we fail to read the event file and fallback to fetching the information from GitHub API. Howver, that's not actually working because the `GITHUB_API_URL` environment is missing. To fix it, we could pass the `GITHUB_API_URL`. However, I think actually making the testdata file available to the container mimics better what happens in real life. Signed-off-by: David Rodríguez <[email protected]>
deivid-rodriguez
force-pushed
the
fix-dev-command
branch
from
0aa4404 to
a9ac792
Compare
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because no testdata files are actually copied to the image, we fail to read the event file and fallback to fetching the information from GitHub API.
Howver, that's not actually working because the
GITHUB_API_URLenvironment is missing.To fix it, we could pass the
GITHUB_API_URL. However, I think actually making the testdata file available to the container mimics better what happens in real life.This is an alternative to #1582.