✨ Add warning for empty repo token #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
force-pushed
the
bug/emptypat
branch
from
943fb31 to
3b1ba3d
Compare
Contributor
Author
|
@nibanks can you try with I'll merge and create a new release after that. Thanks! |
azeemshaikh38
approved these changes
Jan 27, 2022
Sorry, I'm not going to be able to have time to test this today. |
Contributor
Author
|
that's fine. Will wait till you ping back. Any ~ETA (EOW, Monday)? |
laurentsimon
force-pushed
the
bug/emptypat
branch
from
3b1ba3d to
890289b
Compare
Contributor
Author
|
friendly ping. Let me know if this has fixed your problem. |
|
I was just able to validate this, it worked as expected: https://github.com/nibanks/msquic/runs/5024203958?check_suite_focus=true. Thanks! |
nibanks
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entrypoint.sh: add warning if token is empty
Add warning to let users know how to fix an empty PAT token.
Add additional warning if the repo is a fork.
closes #70