Skip to content

🌱 Golang CI for clean code. #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2022
Merged

🌱 Golang CI for clean code. #90

merged 1 commit into from
Feb 7, 2022

Conversation

@naveensrinivasan
Copy link
Member

@naveensrinivasan naveensrinivasan commented Feb 5, 2022 •
edited
Loading

  • Included golangci for clean code.
  • Included go for codeql
  • created a new separate action for the golangci - to keep the action file simple and also it enables them to run cocurrently.
  • Include actions cache for caching workflow runs.

@naveensrinivasan naveensrinivasan force-pushed the naveen/feat/goreleaser branch 14 times, most recently from ed34959 to 44ec617 Compare February 6, 2022 23:10
@naveensrinivasan
🌱 Golang CI for clean code.
25edddb 
Included golangci for clean code.

Signed-off-by: naveen <[email protected]>
naveensrinivasan
naveensrinivasan commented Feb 6, 2022
View reviewed changes
laurentsimon
laurentsimon approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@naveensrinivasan naveensrinivasan merged commit 315c15e into main Feb 7, 2022
@naveensrinivasan naveensrinivasan deleted the naveen/feat/goreleaser branch February 7, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azeemshaikh38 azeemshaikh38 Awaiting requested review from azeemshaikh38

1 more reviewer

@laurentsimon laurentsimon laurentsimon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@naveensrinivasan @laurentsimon