Skip to content

🌱 Add Dart and Flutter CI systems to CI tests check.#1548

Merged
naveensrinivasan merged 2 commits intoossf:mainfrom
godofredoc:add_flutter_ci
Jan 28, 2022
Merged

🌱 Add Dart and Flutter CI systems to CI tests check.#1548
naveensrinivasan merged 2 commits intoossf:mainfrom
godofredoc:add_flutter_ci

Conversation

@godofredoc
Copy link
Copy Markdown
Contributor

The current check is looking at the github checks data to identify whether a given PR ran tests. Flutter and Dart repos are failing the check because their systems are not recognized as CI Systems.

Bug: #1547

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Updates the CI Test check adding new CI Systems.

  • What is the current behavior? (You can also link to an open issue here)
    Only common CI systems are included in the CI Test check and the ones used by Dart and Flutter are not included.

#1547

  • What is the new behavior (if this is a feature change)?
    flutter-dashboard and Cirrus CI will now be recognized as CI systems running tests on the repositories' PRs

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Copy Markdown
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@godofredoc godofredoc temporarily deployed to integration-test January 27, 2022 22:30 Inactive
@github-actions
Copy link
Copy Markdown

naveensrinivasan added a commit that referenced this pull request Jan 27, 2022
Fixed the gofmt issue for the PR #1548
The current check is looking at the github checks data to identify
whether a given PR ran tests. Flutter and Dart repos are failing the
check becuase their systems are not recognized as CI Systems.

Bug: #1547
@godofredoc godofredoc temporarily deployed to integration-test January 28, 2022 01:21 Inactive
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) January 28, 2022 01:22
@github-actions
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: add support for flutter-dashboard and Cirrus CI in the CI Test Check

3 participants