Skip to content

📖 Adding missing documentation for Token-Permissions#1656

Merged
laurentsimon merged 5 commits intoossf:mainfrom
ristomcgehee:perm-docs
Feb 25, 2022
Merged

📖 Adding missing documentation for Token-Permissions#1656
laurentsimon merged 5 commits intoossf:mainfrom
ristomcgehee:perm-docs

Conversation

@ristomcgehee
Copy link
Copy Markdown
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Docs update

  • What is the current behavior? (You can also link to an open issue here)
    The Token-Permissions check documentation does not include documentation on when the score is reduced due to certain write permissions being present on a job.

@ristomcgehee ristomcgehee temporarily deployed to integration-test February 18, 2022 04:15 Inactive
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #1656 (83b8194) into main (4c82c29) will increase coverage by 3.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1656      +/-   ##
==========================================
+ Coverage   58.50%   61.69%   +3.18%     
==========================================
  Files          58       58              
  Lines        5801     5801              
==========================================
+ Hits         3394     3579     +185     
+ Misses       2170     1979     -191     
- Partials      237      243       +6     

@github-actions
Copy link
Copy Markdown

@ristomcgehee ristomcgehee temporarily deployed to integration-test February 19, 2022 03:17 Inactive
@github-actions
Copy link
Copy Markdown

@naveensrinivasan naveensrinivasan temporarily deployed to integration-test February 20, 2022 21:13 Inactive
@github-actions
Copy link
Copy Markdown

@azeemshaikh38 azeemshaikh38 requested review from laurentsimon and removed request for olivekl February 21, 2022 18:04
Copy link
Copy Markdown
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will also wait for @laurentsimon's approval.

Comment thread docs/checks.md Outdated
@ristomcgehee ristomcgehee temporarily deployed to integration-test February 25, 2022 04:52 Inactive
@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris!

@laurentsimon laurentsimon enabled auto-merge (squash) February 25, 2022 22:41
@laurentsimon laurentsimon temporarily deployed to integration-test February 25, 2022 22:41 Inactive
@github-actions
Copy link
Copy Markdown

@laurentsimon laurentsimon merged commit 7610519 into ossf:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants