Skip to content

✨ Raw results for best practices badge#1795

Merged
laurentsimon merged 7 commits intoossf:mainfrom
laurentsimon:feat/rawcii
Apr 25, 2022
Merged

✨ Raw results for best practices badge#1795
laurentsimon merged 7 commits intoossf:mainfrom
laurentsimon:feat/rawcii

Conversation

@laurentsimon
Copy link
Copy Markdown
Contributor

Raw results for best practices badge
No breaking changes

Raw results for best practices badge

@laurentsimon laurentsimon temporarily deployed to integration-test March 29, 2022 21:26 Inactive
@laurentsimon laurentsimon force-pushed the feat/rawcii branch 2 times, most recently from 05204b4 to 444eb43 Compare March 29, 2022 21:30
@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1795 (0c830f7) into main (fe6e091) will decrease coverage by 0.49%.
The diff coverage is 8.19%.

@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   52.29%   51.80%   -0.50%     
==========================================
  Files          77       79       +2     
  Lines        6857     6899      +42     
==========================================
- Hits         3586     3574      -12     
- Misses       3026     3080      +54     
  Partials      245      245              

Copy link
Copy Markdown
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR compiling?

Comment thread checks/cii_best_practices.go Outdated
@laurentsimon
Copy link
Copy Markdown
Contributor Author

Is this PR compiling?

it used to before a rebase. Fixed now.

@laurentsimon laurentsimon reopened this Apr 1, 2022
@laurentsimon laurentsimon temporarily deployed to integration-test April 1, 2022 22:40 Inactive
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2022

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2022

@laurentsimon
Copy link
Copy Markdown
Contributor Author

@azeemshaikh38 PTAL

@laurentsimon laurentsimon temporarily deployed to integration-test April 11, 2022 22:48 Inactive
Copy link
Copy Markdown
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@laurentsimon laurentsimon enabled auto-merge (squash) April 11, 2022 22:54
@github-actions
Copy link
Copy Markdown

@laurentsimon laurentsimon temporarily deployed to integration-test April 14, 2022 01:21 Inactive
@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Stale pull request message

@laurentsimon laurentsimon temporarily deployed to integration-test April 25, 2022 16:45 Inactive
@github-actions
Copy link
Copy Markdown

@laurentsimon laurentsimon merged commit ac88460 into ossf:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants