🐛 Fix bug in docker run scorecard version#1991
Merged
azeemshaikh38 merged 1 commit intomainfrom Jul 6, 2022
Merged
Conversation
azeemshaikh38
requested review from
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1991 +/- ##
==========================================
+ Coverage 50.56% 53.19% +2.62%
==========================================
Files 87 87
Lines 7202 7202
==========================================
+ Hits 3642 3831 +189
+ Misses 3315 3119 -196
- Partials 245 252 +7 |
|
Integration tests success for |
|
Stale pull request message |
naveensrinivasan
force-pushed
the
azeems/scorecard-tag
branch
from
f8f9c5a to
9811eae
Compare
naveensrinivasan
approved these changes
Jul 6, 2022
|
Integration tests success for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently CloudBuild simply tags the Docker image with the version (e.g v4.3.1). But we also need to re-build this Docker image before tagging it so that
scorecard versioncommand returns the right value.(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)