Conversation
|
Need to double check E2E behavior on a repo that doesn't squash commits. When run on |
Codecov Report
@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
- Coverage 42.28% 41.92% -0.36%
==========================================
Files 95 95
Lines 7871 7935 +64
==========================================
- Hits 3328 3327 -1
- Misses 4283 4348 +65
Partials 260 260 |
azeemshaikh38
left a comment
There was a problem hiding this comment.
Awesome work @spencerschrock with the quick turn around here! Can't wait to see this running in prod.
|
Looks like some consistent failures in the e2e token tests. I'll take a look |
May need to include |
45e660f to
febb9ba
Compare
|
Integration tests success for |
|
Integration tests success for |
|
Integration tests success for |
What kind of change does this PR introduce?
Optimization
What is the current behavior?
CheckRunsinfo is fetched via 30 REST API calls.What is the new behavior (if this is a feature change)?**
Caches info about
CheckRunswhich is pulled in during the initial graphQL step without an increase in that API cost (currently cost=1). This makes the info available for theSASTcheck without needing 30 REST API calls.If any uncached info is requested, REST API calls are performed, same as before.
Which issue(s) this PR fixes
Partial fix for #1916
Special notes for your reviewer
Might run into uncached scenarios for repos that don't squash on merge.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)