🐛 Deduplicate projects in cron job by excluding URL queries and fragments#2201
Merged
azeemshaikh38 merged 1 commit intoossf:mainfrom Aug 26, 2022
Merged
🐛 Deduplicate projects in cron job by excluding URL queries and fragments#2201azeemshaikh38 merged 1 commit intoossf:mainfrom
azeemshaikh38 merged 1 commit intoossf:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2201 +/- ##
==========================================
+ Coverage 42.28% 44.68% +2.40%
==========================================
Files 95 95
Lines 7871 7871
==========================================
+ Hits 3328 3517 +189
+ Misses 4283 4087 -196
- Partials 260 267 +7 |
|
Integration tests success for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
cron/internal/data/projects.csvhas duplicate entries, which leads to duplicates in the public BigQuery datae.g.:
In the latest BigQuery data, there are two repos with the name
github.com/adobe-fonts/source-code-pro. One received a score of 4.8 and the other 4.4. The difference is only due to a rate limit error that occurred during one run. They return identical results for me locally.What is the new behavior (if this is a feature change)?**
Uses https://pkg.go.dev/net/url#URL to pull out
hostandpathwhen deduplicatingcron/internal/data/projects.csventries. Ignoring queries, fragments, etc.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Changes to
cron/internal/data/projects.csvwere generated by runningmake add-projectsDoes this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)