🌱 cron: generalize config and create optional values for scorecard and criticality (2/n)

[spencerschrock]

What kind of change does this PR introduce?

Part of a series of refactors to generalize the cron infrastructure to enable re-use by the ossf criticality score project

• PR title follows the guidelines defined in our pull request documentation

What is the current behavior?

Every config value was a top level yaml field

What is the new behavior (if this is a feature change)?**

Only fields which are general enough to be re-used both by scorecard and criticality_score remain as top level fields. Anything specific to either program have been moved into nested fields called scorecard and criticality. These will be parsed as key, value pairs (both strings).

The values can still be overwritten by environment variables. Consider the example below, which can be overridded by setting the environment variable SCORECARD_EXAMPLE_FIELD:

scorecard:
  example-field: foo

• Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

[spencerschrock]

@calebbrown @oliverchang fyi

The map can be fetched with config.GetCriticalityValues(). And the PR/code documents how to override the default values with environment variables. When you add your config values, some unit tests will need to change, but that should more or less be it.

[codecov]

Codecov Report

Merging #2254 (f02f298) into main (9e269b8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2254   +/-   ##
=======================================
  Coverage   44.45%   44.45%           
=======================================
  Files          95       95           
  Lines        7987     7987           
=======================================
  Hits         3551     3551           
  Misses       4173     4173           
  Partials      263      263           

[github-actions]

Integration tests success for
[d53dbea]
(https://github.com/ossf/scorecard/actions/runs/3039621154)

[azeemshaikh38]

Thanks! LGTM with comment

[github-actions]

Integration tests success for
[3a6f554]
(https://github.com/ossf/scorecard/actions/runs/3040477779)