🐛 avoid processing nonexistent codeowner files #4705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This worked with the `archive` file mode, because the code returned a (*os.File)(nil), which could handle the call to Close() on a nil receiver. However due to how the githubrepo client handled reading files in `git` mode, nonexistent files returned a truly nil value, with both the type and value unset. https://go.dev/doc/faq#nil_error Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4705 +/- ##
==========================================
+ Coverage 66.80% 68.29% +1.48%
==========================================
Files 230 249 +19
Lines 16602 18903 +2301
==========================================
+ Hits 11091 12909 +1818
- Misses 4808 5133 +325
- Partials 703 861 +158 🚀 New features to boost your workflow:
|
|
This pull request has been marked stale because it has been open for 10 days with no activity |
raghavkaul
approved these changes
Jul 28, 2025
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
In
archivefile mode, the code returned a (*os.File)(nil), which could handle the call to Close() on a nil receiver. However due to how the githubrepo client handled reading files ingitmode, nonexistent files returned a truly nil value, with both the type and value unset. https://go.dev/doc/faq#nil_error This led to a nil pointer dereference.What is the new behavior (if this is a feature change)?**
We check for two types of nil codeowner files, a nil interface and a nil os.File
Which issue(s) this PR fixes
Fixes #4704
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)