RVM role added #48
Open
RVM role added #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
I'm gonna leave both this and #49 open for the same reasons, namely I'd like some input from @rricard on them (I'm not so much a dev as admin). As long as it's working for you and serves your own needs it's fine in xc-custom/roles until then, but I can definitely see how nvm would be useful for more than just you. And thanks so much for all this and the other PRs! |
|
Yup, auto-install scripts should be available as an option only. What I do usually is to open the script and see what's happening there ... and redo-it properly with ansible. That way I can guarantee the indempotence of the run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this is not the smartest way of having this, and I'm sure it's lacking a lot of options, but... I need this right now. Let's discuss improvements, if you want.