Check the format with Github Action#126
Merged
GabrielSimonetto merged 3 commits intoouch-org:masterfrom Oct 27, 2021
boozec:master
Merged
Check the format with Github Action#126GabrielSimonetto merged 3 commits intoouch-org:masterfrom boozec:master
GabrielSimonetto merged 3 commits intoouch-org:masterfrom
boozec:master
Conversation
Use a job to check the format of the sourcecode with `cargo fmt` command. The new step does not change any code, but returns an error when `check` does not pass with 0 issues.
GabrielSimonetto
approved these changes
Oct 27, 2021
Contributor
GabrielSimonetto
left a comment
There was a problem hiding this comment.
Awesome! Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you can read at this review [1] a format checking is something good to
avoid branch conflitcs etc.
Use a job to check the format of the sourcecode with
cargo fmtcommand. The new step does not change any code, but returns an error
when
checkdoes not pass with 0 issues.[1] #125 (review)