fix: respect file permissions when compressing zip files#271
Merged
marcospb19 merged 2 commits intoouch-org:mainfrom Sep 16, 2022
Merged
fix: respect file permissions when compressing zip files#271marcospb19 merged 2 commits intoouch-org:mainfrom
marcospb19 merged 2 commits intoouch-org:mainfrom
Conversation
Member
Member
Author
|
any updates on this? |
Member
|
Thanks for the ping, I spoke to Vrmiguel and we both agreed on dropping Windows support. I think this PR can be merged as is and then I can create a new issue for dropping the support as a whole, what do you think? |
Member
Author
|
I would be a little hesitant on completely dropping Window support, but I think we could official drop support for Windows and still make it compile on Windows. We can merge this and get more opinions on this in a new issue. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only tested on linux
on unix platforms: keeps file permissions
on non-unix platforms: sets unix permissions to 755 if the file is executable (I'm not sure if I should keep this because iirc ouch doesn't respect permissions when decompressing zip files on non-unix platforms)