Add partial (listing and decompressing only) support for RAR#529
Add partial (listing and decompressing only) support for RAR#529marcospb19 merged 3 commits intoouch-org:mainfrom
Conversation
c1f11ff to
a94da2a
Compare
|
ARMv7 CI failure seems to be an upstream issue: muja/unrar.rs#35 |
|
Thanks for the follow ups! I temporarily disabled ARMv7 to see if CI succeeds in other targets, it's failing on Windows, let me know whether you know how to fix it. |
|
MSVC target on Windows should work fine, it's only MinGW one that fails. In the meantime I've temporarily switched used unrar.rs version to my own fork, which contains all of upstream-proposed fixes. |
|
Situation now seems to be that:
While setting up $PATH variable to MinGW install directory or shipping aforementioned library together with ouch.exe could be considered as a workarounds, but I think that better solution would be to statically link against libstdc++ in ouch executable. |
|
Honestly, I'm absolutely clueless 😄 . |
|
Seems to be working now 😃 |
marcospb19
left a comment
There was a problem hiding this comment.
Seems to be working now 😃
Amazing!
I think it's better not to merge right now because it would block new Ouch releases from happening, I can only publish a version on crates.io when all dependencies are fetched from crates.io itself, I guess we'll have to wait for a new unrar release (but we don't know when that comes out).
Does that make sense to you? 🤔
|
Thanks! And yes, that makes perfect sense to me 👍 |
|
New unrar has finally landed on crates.io :) |
|
That's awesome! Thank you for keeping an eye on that. |
9e11383 to
b8583d7
Compare
Attempt to address #152 using https://github.com/muja/unrar.rs crate.