Store symlinks by default and add --follow-symlinks to toggle it#789
Store symlinks by default and add --follow-symlinks to toggle it#789marcospb19 merged 15 commits intoouch-org:mainfrom
--follow-symlinks to toggle it#789Conversation
…self Signed-off-by: tommady <tommady@users.noreply.github.com>
|
2 years ago I tried this at main...symlinks but couldn't make it work, so I gave up, I even started suspecting there is a problem in the |
ya haha, I saw your PR already, but I saw you said you were facing a panic while archiving which I am not, I found out in your PR you did not give the link type which is required by the append_link function. pleases correct me if I am wrong. right now I am facing the unpack does not unarchive the symlink file out from the test case which I tried to add, but it can work well by the compiled binary... ahah... thanks |
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
|
right now the tar one should be fixed, I am studying the zip one 🙇🏻 |
Oh, I'm glad you're taking a look at it! Really do appreciate the help as I couldn't figure out the solution by myself. Sorry if I worded that ambiguously.
I don't quite recall, but you're right, maybe I forgot to pass the correct argument.
I initially thought that Zip didn't support symlinks 🤦 looks like it does, for this PR we also need to see what's done for 7Zip. |
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
|
Hi, the zip one is fixed, and the 7z does not support symlink compression. |
marcospb19
left a comment
There was a problem hiding this comment.
Tests are great!
Added some comments:
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
--follow-symlinks to toggle it
marcospb19
left a comment
There was a problem hiding this comment.
Looking great! One last thing: please add an entry to CHANGELOG.md so it appears in the release notes. :)
Signed-off-by: tommady <tommady@users.noreply.github.com>
|
Hi @marcospb19, I added the changelog entries. You might modify those if they do not meet the format. |
|
Thanks!! |



Closes #773
Closes #775
Closes #293
Closes #232