refactor: better NO_COLOR support#95
Merged
marcospb19 merged 2 commits intoouch-org:masterfrom Oct 15, 2021
figsoda:refactor-colors
Merged
refactor: better NO_COLOR support#95marcospb19 merged 2 commits intoouch-org:masterfrom figsoda:refactor-colors
marcospb19 merged 2 commits intoouch-org:masterfrom
figsoda:refactor-colors
Conversation
Member
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62
Fixes #66
colors::*are now lazy statics that respect NO_COLOR instead of pure functionscolors::yellow()->*colors::YELLOWif *NO_COLOR_IS_SETis no longer needed outside ofcolorsmoduleswitched from lazy_static to once_cell since it doesn't use macros and the code can look a little cleaner