Repository navigation
CI: nothing is published when a test fails #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dylan-conway
wants to merge
3
commits into
main
Choose a base branch
from
claude/tests-gate-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−15
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Every push to main and every PR will now run 30 test legs instead of 2, and any one of them failing deletes the release. The block at lanes.mjs:323-327 is commented "TEMPORARY, not for merging" but is still here:
TEST_REPEATS = 15fans each tested lane out into 15 matrix entries. Sincereleasenow needstest, one flaky leg out of 30 blocksautobuild-{sha}. Fix: revert the TEST_REPEATS scaffolding soplanemits one test entry per tested lane, and drop the matchingmatrix.repeatbits at ci.yml:315 and ci.yml:494. The PR description only mentions reverting the failing-test commit, not this one.Extended reasoning...
lanes.mjs:325 sets
TEST_REPEATS = 15; line 327 flatMaps each tested lane overrepeats, so thetestmatrix has 2 lanes × 15 = 30 entries. ci.yml:514 addstesttorelease.needs, and ci.yml:528 marks the run failed if any needed job did not succeed, so a single flaky leg out of 30 deletes the draft (ci.yml:551) and nothing is published. The PR itself citesstress/sampling-profiler-bound-function-name.jsfailing ~3/334 on Linux x64; across 15 x64 runs that is roughly a 13 % chance per push, before counting arm64. On the base branch there were 2 legs and they did not gate the release at all. CI cost also rises ~15×: 30 jobs of ~11 minutes each on every run. The comment on line 323 explicitly says "TEMPORARY, not for merging". Related scaffolding that should go with it: ci.yml:315 appends#${{ matrix.repeat }}to the job name (which YAML actually treats as a comment because of the space before#, so the repeat number never shows anyway) and ci.yml:494 appends-${{ matrix.repeat }}to the artifact name.Verification: normal — acknowledged in diff: the comment "TEMPORARY, not for merging" (lanes.mjs:323) is accurate and the note's claim holds, but the scaffolding is still in the change being merged; removing it leaves the PR's stated purpose (tests gate the release) met in full. .github/scripts/lanes.mjs:325 sets
const TEST_REPEATS = 15;and :327 emits `test=${matrix(lanes.filter(lane =>… | normal — the…There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is deliberate and temporary: the 15x fan-out is there to count intermittently failing tests before the gate goes in, and it is reverted before this is merged. The pull request description did not say so and now does ("Not for merging yet"). Leaving this thread open until the revert is pushed.