Skip to content

[WTF] StringBuilder: tryAppend, tryToString and tryReserveCapacity leave the builder unchanged on failure - #737

Draft
robobun wants to merge 4 commits into
mainfrom
robobun/1fc2b675/stringbuilder-try-api
Draft

robobun wants to merge 4 commits into
mainfrom
robobun/1fc2b675/stringbuilder-try-api

StringBuilder tests: the helper of the debug tests is inside their block

ba195ce
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 29, 2026 in 17m 24s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:677 nit: developers running TestWTF from a debug build configured with ENABLE_MALLOC_HEAP_BREAKDOWN=ON (the macOS debug lane