Repository navigation
[WTF] Give WTF threads an alternate signal stack and make the suspend handler work on one - #742
Open
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Sep 30, 2026 in 38m 11s
Code review found 4 potential issues
Found 9 candidates, confirmed 4. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 4 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | Source/WTF/wtf/posix/ThreadingPOSIX.cpp:222 |
Anyone building this fork for a Linux or FreeBSD CPU other than x64 or arm64 gets a hang in every suspension of a WTF th |
| 🟡 Nit | JSTests/stress/sampling-profiler-thread-on-alternate-signal-stack.js:10 |
Maintainers get a new stress test that breaks the JSTests/README.md rules for new tests: it runs well over the 200 ms bu |
| 🟡 Nit | Source/WTF/wtf/posix/ThreadingPOSIX.cpp:362 |
Every WTF thread in Bun release builds now costs twice the mapped address space and commit charge, and two extra VMAs, s |
| 🟡 Nit | JSTests/stress/sampling-profiler-thread-on-alternate-signal-stack.js:18 |
nit: The new test builds and runs a WebAssembly module, but JSTests/README.md says tests that involve wasm belong in JST |
Loading