Repository navigation
Upgrade to upstream WebKit f59345e04a8d - #889
Code review found 1 important issue
Found 13 candidates, confirmed 3. See review comments for details.
This review did not follow any REVIEW.md files in this repository's folders or any CLAUDE.md files, and did not see the pull request's title or description, because it could not confirm the full list of files this pull request changes. This pull request changes so many files that the review planned its work from the changed folders, not from the full list of files, and may have looked less closely at some files. Pull requests that change fewer than 300 files avoid this.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | Source/JavaScriptCore/runtime/CachedTypes.cpp:5324 |
Embedders whose on-disk bytecode cache was written by a build at bun/main (revision 14, pre-merge opcode numbering) will |
| 🟡 Nit | Source/WebCore/loader/TextResourceDecoder.cpp:566 |
Web extensions whose JSON, JS or text resource is 1 or 2 bytes now get an empty string for it instead of its contents. T |
| 🟡 Nit | Source/WebCore/loader/FrameLoader.cpp:910 |
Developers on builds where COOP is disabled get a self-contradictory warning: "the Cross-Origin-Opener-Policy header val |
Annotations
Check failure on line 5324 in Source/JavaScriptCore/runtime/CachedTypes.cpp
claude / Claude Code Review
Embedders whose on-disk bytecode cache was written by a build at bun/main (revision 14, pre-merge opcode numbering) will have it accepted by this build and decoded with shifted opcode IDs, so cached code mis-executes or crashes instead of being rejected.
Embedders whose on-disk bytecode cache was written by a build at bun/main (revision 14, pre-merge opcode numbering) will have it accepted by this build and decoded with shifted opcode IDs, so cached code mis-executes or crashes instead of being rejected. The merge removes op_is_big_int from BytecodeList.rb, renumbering every opcode after it, but cachedTypesFormatRevision at CachedTypes.cpp:5324 stays at 14, which e450c494a8 already used for the loop-header change on the old numbering. Fix: bump