Repository navigation
fix(install): handle transitive folder dependencies - #10445
Merged
Merged
Conversation
Contributor
|
❌ @dylan-conway, your commit has failing tests :( 💻 2 failing tests Darwin x64 baseline
🐧🖥 1 failing tests Linux x64 baseline
🪟💻 1 failing tests Windows x64 baseline
🪟💻 3 failing tests Windows x64
|
Jarred-Sumner
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for writing these tests
I think everything in the PR fine except for the verify symlink part. That part should be changed to either:
- do no checks at all, just verify package.json version like we do elsewhere
- verify each symlink by re-creating it. it's just as expensive to create a bunch of symlinks as it is to check if those symlinks are valid. and, checking if symlinks are valid is a TOCTOU race condition
dylan-conway
marked this pull request as ready for review
June 13, 2024 06:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sometimes packages are published with
file:dependencies. The pr installs them with symlinks, without erroring if the target does not existfixes #10324
fixes #11519
How did you verify your code works?
added tests