-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(node/os): implement os.machine()
#1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Someone responded to my question related to finding the machine on darwin (kernel in the Zig discord):
Going to dissect this and hopefully use it to implement the behavior in this PR when I find some time. |
|
if all we want is CPU_ARCH bun is statically compiled we can just use if (Environment.isAARCH64)
return "aarch64";
else if (Environment.isX64)
return "x64";etc |
|
Hmm yeah, not sure about all those other options, though. I guess we would have to ship specific executables to run on those archs so it's fine to just include |
|
Alright, I renamed the option to |
|
Fixes #1981 |
|
@sno2 Thank you for this PR and sorry about the delay. I am interested in getting this merged up once we get builds passing. |
Ref: https://nodejs.org/api/os.html#osmachine
Please wait on CI/CD, not sure about Darwin stuff and I don't have a mac to test it on.