Skip to content

Fixes ^C on bun vite - #15545

Merged
Jarred-Sumner merged 4 commits into
mainfrom
pfg/fix-ctrl-c
Dec 4, 2024
Merged

Jarred-Sumner merged 4 commits into
mainfrom
pfg/fix-ctrl-c

Conversation

@pfgithub

@pfgithub pfgithub commented Dec 3, 2024 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes:

$> bun init -y
$> bun add vite
$> bun vite
^C

before:
  - error: Failed to run "vite" due to signal SIGINT
  - doesn't exit or respond to ^C anymore
after: (exits with code SIGINT)

How did you verify your code works?

Added tests

TODO

  • Fix tests on windows (on windows, expect exitCode: 1, signalCode: null)
  • Why does it not work with the restored signal handler? In the debugger, trigger the signal and then put a breakpoint on raise and see what happens inside the signal handler

Closes #14375

@robobun

robobun commented Dec 3, 2024 •

Copy link
Copy Markdown
Collaborator

❌ @pfgithub, your commit e5a2e7c has 13 failures in #7258:

  • test/regression/issue/09041.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 2019 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/cli/hot/hot.test.ts - 2 failing on 🪟 2019 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 22.04 x64
  • test/js/node/process/process.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - SIGTRAP on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64-baseline
  • test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64
  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64
  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/cli/install/bun-run.test.ts - 1 failing on 🐧 3.20 x64
  • test/bake/dev/esm.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • @Jarred-Sumner

    Copy link
    Copy Markdown
    Collaborator

    I'm surprised there's no github issue for this

    @robobun

    robobun commented Oct 16, 2026

    Copy link
    Copy Markdown
    Collaborator

    The vite install that this PR added to ctrl-c.test.ts made CI red on 2026-10-13: npm returned 404 for a rollup tarball right after its publish (build 125085). #45542 replaces the install with a local package.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Cannot exit "bun tsc -w" since v1.1.27

    3 participants