Skip to content

+13 passing node:vm tests - #15865

Merged
Jarred-Sumner merged 13 commits into
mainfrom
jarred/nodevm
Dec 19, 2024
Merged

Jarred-Sumner merged 13 commits into
mainfrom
jarred/nodevm

Conversation

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

What does this PR do?

This brings our node:vm implementation closer to Node's.

Fixes #11797
Fixes #4205
Fixes #5658
Properly fixes #5847 (happy-dom can delete their workaround)
Fixes #6594

Probably fixes (unconfirmed)

How did you verify your code works?

Node tests!

@robobun

robobun commented Dec 19, 2024 •

Copy link
Copy Markdown
Collaborator
Updated 7:57 PM PT - Dec 18th, 2024

✅ @Jarred-Sumner, your commit 8cee321 has passed in #8192! 🎉


🧪   try this PR locally:

bunx bun-pr 15865

Comment thread src/bun.js/bindings/NodeVM.cpp Resolved
Comment thread src/bun.js/bindings/NodeVM.cpp Resolved
@Jarred-Sumner
Jarred-Sumner merged commit ac6723e into main Dec 19, 2024
@Jarred-Sumner
Jarred-Sumner deleted the jarred/nodevm branch December 19, 2024 03:41
Jarred-Sumner added a commit that referenced this pull request Dec 19, 2024
@Spixmaster

Copy link
Copy Markdown

@Jarred-Sumner Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants