Repository navigation
+13 passing node:vm tests - #15865
Merged
Merged
Conversation
Collaborator
|
Updated 7:57 PM PT - Dec 18th, 2024
✅ @Jarred-Sumner, your commit 8cee321 has passed in 🧪 try this PR locally: bunx bun-pr 15865 |
dylan-conway
approved these changes
Dec 19, 2024
|
@Jarred-Sumner Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This brings our node:vm implementation closer to Node's.
Fixes #11797
Fixes #4205
Fixes #5658
Properly fixes #5847 (happy-dom can delete their workaround)
Fixes #6594
Probably fixes (unconfirmed)
happy-domcauses console.log() to not print during tests #6044How did you verify your code works?
Node tests!