[jest] fix and improve hooks #1689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
In a future PR we should support the |
alexlamsl
changed the title
beforeAll() to completebeforeAll() to complete
alexlamsl
force-pushed
the
issue-1688
branch
from
bac7f72 to
4d91c94
Compare
alexlamsl
changed the title
beforeAll() to completebeforeAll() to complete
alexlamsl
force-pushed
the
issue-1688
branch
from
4d91c94 to
18cf2e9
Compare
alexlamsl
changed the title
beforeAll() to complete
Contributor
Author
rolled into this PR 😉 |
alexlamsl
force-pushed
the
issue-1688
branch
from
18cf2e9 to
96afb4c
Compare
alexlamsl
changed the title
- wait for async hooks to complete before running tests - add support for `done(err)` callbacks in hooks fixes oven-sh#1688
alexlamsl
force-pushed
the
issue-1688
branch
from
96afb4c to
01649b4
Compare
alexlamsl
changed the title
Collaborator
|
great |
Jarred-Sumner
pushed a commit
that referenced
this pull request
Jan 6, 2023
- wait for async hooks to complete before running tests - add support for `done(err)` callbacks in hooks fixes #1688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done(err)callbacks in hooksfixes #1688