implement `net.Socket` #1701

alexlamsl · 2023-01-02T20:55:43Z

support TCP sockets for now, i.e. no IPC
extra features like keep-alive, no-delay etc. are absent due to limitations of uSockets
fix jest to treat done(nullish) as success

Jarred-Sumner · 2023-01-02T20:57:24Z

extra features like keep-alive, no-delay etc. are absent due to limitations of uSockets

We can change this manually ourselves but it's fine for a follow-up. We would call setsocketopt on the file descriptor (which we would need to handle specially for TLS), which is how usockets itself would do it.

Jarred-Sumner · 2023-01-02T20:57:50Z

done(nullish)

Is that consistent with what Jest does?

alexlamsl · 2023-01-02T20:58:45Z

Is that consistent with what Jest does?

AFAICT, yes.

src/bun.js/net.exports.js

test/bun.js/socket/node-net.test.ts

src/bun.js/net.exports.js

Jarred-Sumner · 2023-01-02T22:35:55Z

src/bun.js/net.exports.js

+      const self = socket.data;
+      self.bytesRead += buffer.length;
+      if (self.#readQueue.isEmpty()) {
+        if (self.push(buffer)) return;


Do we return Buffer objects in the stream class? We could add a flag to do that here because IIRC, node:stream will internally create a Buffer object

Technically Uint8Array (so basically Buffer from Node.js PoV) − will investigate if node:stream does extra allocation or not 🤔

yeah it does in the streams code when you push a Uint8Array, it creates a new Buffer

- support TCP sockets for now, i.e. no IPC - extra features like keep-alive, no-delay etc. are absent due to limitations of uSockets - fix `jest` to treat `done(nullish)` as success

Jarred-Sumner · 2023-01-02T22:40:07Z

src/bun.js/net.exports.js

+  }
+
+  _write(chunk, encoding, callback) {
+    if (typeof chunk == "string" && encoding !== "utf8") chunk = Buffer.from(chunk, encoding);


If we split this into two functions it might be faster:

if (typeof chunk === "string") this.#writeString(chunk, callback)

this.#writeBuffer(chunk, callback)

We could also add a DOMJIT binding for writeText / writeBytes, as we have done for ServerWebSocket and then we can have lower function call overhead in these functions. It would only shave off around 20ns though

Just to clarify, the above code is there to handle things like socket.setEncoding("hex").write("deadbeef"), i.e. for correctness rather than performance

- support TCP sockets for now, i.e. no IPC - extra features like keep-alive, no-delay etc. are absent due to limitations of uSockets - fix `jest` to treat `done(nullish)` as success