[streams] speed up Readable in some cases
#1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I wonder if we could do this for any ArrayBufferView since StringDecoder is allowed to be used with any ArrayBufferView |
Contributor
Author
|
I think the answer is yes, though I couldn't come up with any (common) use cases for that. May be extend further support when the time comes? 🤔 |
alexlamsl
force-pushed
the
streams-uint8array
branch
2 times, most recently
from
e731c7e to
c6cea6e
Compare
alexlamsl
changed the title
Readable in some casesReadable in some cases
If `encoding` is set, no `Buffer`s would be exposed thus `Uint8Array` can be used directly. - fix data corruption in `BufferList.concat()` - fix segfaults in `BufferList.join()`
alexlamsl
force-pushed
the
streams-uint8array
branch
from
c6cea6e to
a993f41
Compare
alexlamsl
changed the title
Readable in some casesReadable in some cases
Jarred-Sumner
pushed a commit
that referenced
this pull request
Jan 6, 2023
If `encoding` is set, no `Buffer`s would be exposed thus `Uint8Array` can be used directly. - fix data corruption in `BufferList.concat()` - fix segfaults in `BufferList.join()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
encodingis set, noBuffers would be exposed thusUint8Arraycan be used directly.Measured 15% performance increase with
tcp-echo.node.mjsVerified with:
child-process-stdio.test.jsfs.test.jswith 1 pre-existing failurenode-net.test.tsnode-stream.test.jsprocess-stdio.test.ts