Support non-classes in node:net

[Jarred-Sumner]

Packages sometimes call Socket() instead of new Socket

Is this a suitable workaround without converting to prototype object/non-class? @alexlamsl

[Jarred-Sumner]

This doesn't work for Socket.prototype.constructor === Socket checks, which makes sense

hm

[alexlamsl]

This should work:

--- a/src/bun.js/net.exports.js
+++ b/src/bun.js/net.exports.js
@@ -57,7 +57,17 @@ const { Bun, createFIFO } = import.meta.primordials;
 const { connect: bunConnect } = Bun;
 const { Duplex } = import.meta.require("node:stream");
 
-export class Socket extends Duplex {
+export const Socket = function(InternalSocket) {
+  return Object.defineProperty(function Socket(options) {
+    return Object.defineProperty(new InternalSocket(options), "constructor", {
+      value: Socket,
+    });
+  }, Symbol.hasInstance, {
+    value(instance) {
+      return instance instanceof InternalSocket;
+    },
+  });
+}(class Socket extends Duplex {
   static #Handlers = {
     close: Socket.#Close,
     connectError(socket, error) {
@@ -286,7 +296,7 @@ export class Socket extends Duplex {
       this.#writeChunk = chunk;
     }
   }
-}
+});
 
 export function createConnection(port, host, connectListener) {
   if (typeof host == "function") {