[WIP] fix(node:fs): export fs.ReadStream and fs.WriteStream

[ThatOneBro]

Fixes #1797 and adds a few tests

[Jarred-Sumner]

Can you add a test that checks if it works when using export from and export * from? Wondering what the compiler will do

[ThatOneBro]

Can you add a test that checks if it works when using export from and export * from? Wondering what the compiler will do

Ah you're right, compiler doesn't like this. Is there any workaround that you can think of?

SyntaxError: Import named 'ReadStream' not found in module '/Users/derrick/repos/bun-stuff/new/bun/test/fixtures/export-lazy-fs-streams/export-*-from.ts'.

and

SyntaxError: Indirectly exported binding name 'ReadStream' is not found.

[ThatOneBro]

Ok maybe this isn't worth it, but we could potentially create stub class functions that when constructed lazy load the real ReadStream or WriteStream, so the classes can be loaded without node:stream initially, even in the case where they are re-exported. It would fail an instanceof check, but maybe we can do something clever like the trick used for constructors without new.

Does that make sense at all?

[ThatOneBro]

Oops, just realized I made a noob mistake with the Symbol.hasInstance comparison lol

[ThatOneBro]

Update: fs.ReadStream !== reexportedReadStream // result: true when it should be false. Need another solution, possibly make every instance of fs.ReadStream a wrapper and at the time of construction of the first instance, load node:stream and patch the prototype chain of fs.ReadStream and the instance with the newly loaded NativeReadable subclass. Or we can abandon lazy-loading altogether. But that is costly to startup times as node:stream is very heavy...

[Jarred-Sumner]

Thank you