fix life-cycle script execution #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change current working directory for workspaces - add `node_modules/.bin` to `PATH` before running
Jarred-Sumner
approved these changes
Jan 15, 2023
| var needs_colon = false; | ||
| if (package_json_dir.len > 0) { | ||
| defer needs_colon = true; | ||
| if (needs_colon) { |
Collaborator
There was a problem hiding this comment.
This branch will always be true
Contributor
Author
There was a problem hiding this comment.
would this defer be executed at the end of if (package_json_dir.len > 0) {...}? 🤔
|
|
||
| pub const Scripts = struct { | ||
| const StringArrayList = std.ArrayListUnmanaged(string); | ||
| const Entry = struct { |
Collaborator
There was a problem hiding this comment.
we almost could add a --filter with this! Just missing another map to say "which package.json name does it belong to"
Collaborator
|
Looks good, thanks for fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_modules/.bintoPATHbefore running