Repository navigation
fix: detection module type from extension - #18562
Merged
Merged
Conversation
Collaborator
|
Updated 8:00 PM PT - Mar 27th, 2025
✅ @paperclover, your commit 7589a68bda4cfe8dd8ed7eab9ab31ea5f5169488 passed in 🧪 try this PR locally: bunx bun-pr 18562 |
Jarred-Sumner
added a commit
that referenced
this pull request
Mar 28, 2025
This reverts commit 8f4575c.
Jarred-Sumner
added a commit
that referenced
this pull request
Mar 29, 2025
Merged
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18533.
Additionally this fixes having a CJS file with ES import statement, which unregresses another 1.2.7 bug tho idk if its reported.
In 1.2.7 (specifically #18086) we regressed how Bun picks what module type a file is. The patch there did not consider file extensions. No we do this logic.
to see this visually, here is the drift from 1.2.6
[type field in package.json] [filename] -> [resolved module type]for comparison, the drift from 1.2.7. notice how MJS and CJS is not respected.